Skip to content

fix: Improve accessibility of colour slider plugin#2745

Merged
gonfunko merged 1 commit into
mainfrom
colour-sliders
Jul 9, 2026
Merged

fix: Improve accessibility of colour slider plugin#2745
gonfunko merged 1 commit into
mainfrom
colour-sliders

Conversation

@gonfunko

@gonfunko gonfunko commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

The basics

The details

Proposed Changes

This PR improves the accessibility of the HSV colour slider plugin, and fixes a few bugs as well. It:

  • Fixes focusing the first slider when the dropdown is opened
  • Allow comitting the chosen color with Enter/Space
  • Adds support for canceling and reverting to the previously selected color with Escape
  • Adds ARIA labels to each of the sliders
  • Indicates that the field has a menu popup, rather than the inherited grid
  • Uses the standard focus ring indicator for the field, sliders, and eyedropper button
  • Fixes a bug that would cause an exception to be thrown when dismissing the eyedropper with Escape
  • Generates a description of the chosen color. This generally works well for pleasant colors, but very desaturated/dark ones are perhaps not ideal. This also would ideally be localized, but this is a bit of placeholder that will hopefully be replaced with something better soon-ish

@gonfunko gonfunko requested a review from a team as a code owner July 1, 2026 19:07
@gonfunko gonfunko requested review from lizschwab and removed request for a team July 1, 2026 19:07
@gonfunko gonfunko merged commit a2a7dab into main Jul 9, 2026
6 checks passed
@gonfunko gonfunko deleted the colour-sliders branch July 9, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants