fix: Fix positioning of dropdown on full-block color fields#2747
Merged
Conversation
maribethb
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #2742
Proposed Changes
This PR fixes a bug that caused the dropdown to be mispositioned for full-block color fields. Previously, these fields were always creating a border rect and setting it hidden if they were full-block; the superclass however used the presence or absence thereof as a proxy for being full-block when computing the field's bounding box, causing an incorrect bounding box to be generated for a full-block color field, which in turn caused the dropdowndiv to position itself incorrectly. Now, the color field only creates a border rect if it's not full-block.