Skip to content

Rails 7 -> 8.0.5#815

Merged
abcampo-iry merged 3 commits into
mainfrom
rails-8.0.4
May 13, 2026
Merged

Rails 7 -> 8.0.5#815
abcampo-iry merged 3 commits into
mainfrom
rails-8.0.4

Conversation

@abcampo-iry
Copy link
Copy Markdown
Contributor

@abcampo-iry abcampo-iry commented May 11, 2026

Status

  • Closes: Not fully closing
  • Related to 1291

Points for consideration:

  • Upgrade of syntax to comply with 8.x version

What's changed?

It has been upgraded rails 7 to rails 8.0.4 following the conversations from the Issue above and #784

@cla-bot cla-bot Bot added the cla-signed label May 11, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

Test coverage

91.05% line coverage reported by SimpleCov.
Run: https://github.com/RaspberryPiFoundation/editor-api/actions/runs/25787243937

@abcampo-iry abcampo-iry marked this pull request as ready for review May 11, 2026 08:18
Copilot AI review requested due to automatic review settings May 11, 2026 08:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the application from Rails 7.2 to Rails 8.x, updating configuration defaults, strong-parameter handling, and tests to match new Rails behaviors (notably ActionController::Parameters#expect and updated exception messages).

Changes:

  • Bump Rails dependency and framework defaults to Rails 8 (Gemfile/Gemfile.lock + config.load_defaults).
  • Replace require(...).permit(...) strong params with params.expect(...) in several API controllers.
  • Adjust request/spec helpers for rake task loading/reenabling and update brittle expectation(s) affected by Rails 8.

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
spec/requests/test_utilities_spec.rb Updates rake task handling around request specs.
spec/requests/api_controller_spec.rb Updates expected ParameterMissing error message for Rails 8.
spec/rails_helper.rb Loads rake tasks once per suite and reenables tasks around type: :task specs.
spec/features/school_class/listing_school_classes_spec.rb Makes assertions order-independent by locating classes by name.
Gemfile.lock Resolves Rails and related gems to Rails 8.x versions.
Gemfile Updates Rails dependency requirement to ~> 8.0.4.
config/application.rb Updates config.load_defaults to 8.0.
app/controllers/api/subscriptions_controller.rb Switches strong params to params.expect.
app/controllers/api/schools_controller.rb Switches strong params to params.expect.
app/controllers/api/school_teachers_controller.rb Switches strong params to params.expect.
app/controllers/api/school_students_controller.rb Switches strong params to params.expect.
app/controllers/api/school_classes_controller.rb Switches strong params to params.expect.
app/controllers/api/projects/remixes_controller.rb Switches strong params to params.expect (includes nested params).
app/controllers/api/google_auth_controller.rb Switches strong params to params.expect.
app/controllers/api/class_members_controller.rb Switches strong params to params.expect.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/controllers/api/projects/remixes_controller.rb
Comment thread Gemfile Outdated
@abcampo-iry abcampo-iry changed the title Rails 7 -> 8.0.4 Rails 7 -> 8.0.5 May 11, 2026
Comment thread app/controllers/api/google_auth_controller.rb Outdated
Copy link
Copy Markdown
Contributor

@zetter-rpf zetter-rpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just one question from your past self

Also, do you think we should we do any additional testing or monitoring given it's a major upgrade?

@abcampo-iry
Copy link
Copy Markdown
Contributor Author

👍 Just one question from your past self

Also, do you think we should we do any additional testing or monitoring given it's a major upgrade?

@zetter-rpf Yes, after deploy, I’d watch logs and request metrics for increased 4xx/5xx rates, ActionController::ParameterMissing, unexpected auth failures, Google OAuth exchange failures, and any latency/error-rate changes on core endpoints.

@zetter-rpf
Copy link
Copy Markdown
Contributor

@zetter-rpf Yes, after deploy, I’d watch logs and request metrics for increased 4xx/5xx rates, ActionController::ParameterMissing, unexpected auth failures, Google OAuth exchange failures, and any latency/error-rate changes on core endpoints.

Great. I think you can see most of that in Sentry, but let me know if I can help with that as there's also similar information in betterstack that we could look at together.

@abcampo-iry abcampo-iry merged commit b94245f into main May 13, 2026
5 checks passed
@abcampo-iry abcampo-iry deleted the rails-8.0.4 branch May 13, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants