fix(store): support LIST columns in parted fill - #402
Merged
Conversation
singaraiona
marked this pull request as ready for review
August 14, 2026 13:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RAY_LISTcolumns withray_list_new(0)during.db.parted.fillRoot cause
empty_table_likepassed every dynamic column type toray_vec_new.RAY_LISTis type code0, whileray_vec_newonly accepts positive concrete vector types, so gap-filling a table with a LIST column failed. The fill loop then replaced the underlying error with a genericioerror.Impact
Parted roots can now gap-fill tables containing LIST columns, including LIST-of-DICT data. When fill fails for another reason, callers receive the real error category and actionable table/partition context.
Validation
make -j2RAYFORCE_CORES=2 ./rayforce.test -f splay_empty_list_column_roundtripRAYFORCE_CORES=2 ./rayforce.test -f db_parted_fillmake test TEST_CORES=2— 3,677/3,677 passedFixes #401