Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
ran my dependency checker (ghost-deps) on openapi-sampler after the move to Rollup. it flags
babel-loader,json-loaderandcore-jsas unused dev dependencies. i couldn't find references outside package.json and the lockfile; the current build uses Rollup, not webpack.this adds ghost-deps as an advisory CI check, without removing any packages or failing your build. i'm the author of ghost-deps. if this isn't useful here, no worries.
Testing
workflow-only change; no dependency removal tested. the finding is from a static scan and source/config review.
Security
uses pinned action and checkout commits with scoped workflow permissions; no repository code changes.