fix(font-gate): enforce fail-closed font coverage parsing (RIG-3742) - #1294
Open
rigel-mintaka wants to merge 5 commits into
Open
rigel-mintaka wants to merge 5 commits into
rigel-mintaka wants to merge 5 commits into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
rigel-mintaka
marked this pull request as ready for review
September 18, 2026 18:16
|
Compass engineering docs preview: https://compass-ux-3742-font-gate-er.compass-eng-docs.pages.dev Deployed from |
rigel-mintaka
force-pushed
the
compass-ux/3742-font-gate-error
branch
from
September 18, 2026 19:32
0e1e34a to
7b70c17
Compare
rigel-mintaka
added this pull request to stack #1306
September 18, 2026 20:16
rigel-mintaka
changed the title
mattwilkinsonn
approved these changes
Sep 21, 2026
|
Stacked PR 1314 failed testing in the merge queue. Please investigate the failure and re-submit the stack. |
Make malformed cmap ranges fail closed before expansion, and update the T8 rollout comments and mode contract. Add regression coverage for hostile ranges and the CLI default.\n\nSpec-impact: none. Refs RIG-3742.
Replace the remaining terminal arrows and progress bullets with ASCII so the fail-closed font gate passes the real UI source tree.\n\nSpec-impact: none. Refs RIG-3742.
Reject glyphless format-12 mappings, cover shared cmap budgets and CLI modes with regression tests, and keep the gate documentation aligned with the Space Mono contract.\n\nSpec-impact: none. Refs RIG-3742.
Bound cmap reads to declared table and subtable extents, reject glyph-ID overflow, and validate mapped IDs against maxp.numGlyphs. Add malformed-font regressions and invalidate font-gate tests when bundled fonts change.\n\nSpec-impact: none. Refs RIG-3742.
rigel-mintaka
force-pushed
the
compass-ux/3742-font-gate-error
branch
from
September 23, 2026 01:08
f3f1443 to
b54f591
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.