feat(fabric): let a subscriber callback fail so the event is redelivered (RIG-4030) - #1355
Draft
rigel-mintaka wants to merge 2 commits into
Draft
rigel-mintaka wants to merge 2 commits into
rigel-mintaka wants to merge 2 commits into
Conversation
…red (RIG-4030) The EventFabric callback now returns an error. nil acks; an error or a panic Naks through retryOrPark and parks on DLQSubject at MaxDeliver. Delivery returns an error for a transient read before any hold or dispatch, and nil for a missing row or a deliberate skip, so a retry starts clean. Reads inside fanOut still log and ack, since a retry would repeat mention steers. hold keeps held entries in commit order, so a redelivered ref cannot fire behind a later one. Also proves the cutover record T4 (b)/(c): error redelivery to MaxDeliver and the DLQ park with Compass-Original-Subject. Built on the recommended option; draft until that decision is ruled. Spec-impact: pending RIG-4030 (the callback signature in the cutover record T2 Interfaces line). Refs RIG-4030, RIG-3107 Co-authored-by: Matt Wilkinson <matt@rigel.build>
This was referenced Sep 26, 2026
Draft
Spec-impact: none. Refs RIG-4030 Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Compass engineering docs preview: https://compass-managed-rig-4030-cal.compass-eng-docs.pages.dev Deployed from Changed pages: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 6 PRs:
mainThe EventFabric callback now returns an error. nil acks; an error or a
panic Naks through retryOrPark and parks on DLQSubject at MaxDeliver.
Delivery returns an error for a transient read before any hold or
dispatch, and nil for a missing row or a deliberate skip, so a retry
starts clean. Reads inside fanOut still log and ack, since a retry would
repeat mention steers. hold keeps held entries in commit order, so a
redelivered ref cannot fire behind a later one.
Also proves the cutover record T4 (b)/(c): error redelivery to MaxDeliver
and the DLQ park with Compass-Original-Subject.
Built on the recommended option; draft until that decision is ruled.
Spec-impact: pending RIG-4030 (the callback signature in the cutover
record T2 Interfaces line). Refs RIG-4030, RIG-3107
Co-authored-by: Matt Wilkinson matt@rigel.build