docs(ui): record --pink remap in the DS token cutover (RIG-2008) - #1357
Closed
rigel-mintaka wants to merge 1 commit into
Closed
rigel-mintaka wants to merge 1 commit into
rigel-mintaka wants to merge 1 commit into
Conversation
The cutover record still said `--pink` had zero consumers and would be deleted outright. #357 instead remapped it: `.msg.system .msg-role` now reads `--cx-author-system: var(--rigel-magenta)` (`tokens.css:156-157`). This change updates the record to match, in section (a), the mapping table, and T5. Spec-impact: none. Refs RIG-2008 Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
Author
|
Closing: compass AGENTS.md says a merged design record is amended by a new record, not rewritten in place. The remap itself shipped in #357, and RIG-2008 closes on that evidence. A new amendment record for one token is not worth it. |
|
Compass engineering docs preview: https://compass-ux-2008-pink-remap-r.compass-eng-docs.pages.dev Deployed from Changed pages: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cutover record still said
--pinkhad zero consumers and would be deleted outright. #357 instead remapped it:.msg.system .msg-rolenow reads--cx-author-system: var(--rigel-magenta)(tokens.css:156-157). This change updates the record to match, in section (a), the mapping table, and T5.Spec-impact: none. Refs RIG-2008
Co-authored-by: Matt Wilkinson matt@rigel.build