docs: drop frozen-contract framing from records, comments and protos (RIG-2677) - #1359
Open
rigel-mintaka wants to merge 3 commits into
Open
rigel-mintaka wants to merge 3 commits into
rigel-mintaka wants to merge 3 commits into
Conversation
…(RIG-2677) Pre-GA nothing is frozen, so records and code comments no longer cite frozenness, or a merged half's existence, as the reason for a design choice. Each now states the design on its own terms. Decisions are unchanged. Record change-control, ledger history, and non-framing senses of the word are kept. Generated Go/TS and sqlc output are regenerated from the edited .proto and query comments. Decisions that rested only on a freeze are listed in RIG-4041 for their own design pass. Refs RIG-2677 Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
…e (RIG-2677) Review found spots where removing 'frozen' also dropped a real rule. Those rules are now stated on their own terms: arm numbers are not renumbered, Resize means C3 needs no interface change, and HMAC amends the SHA-256 choice. DL mirrors and change-control wording now match DECISIONS.md again. Every edited file keeps main's line count, so inbound path:line cites still resolve. Missed framing in proto/moon.yml, fabric, tests, and the brand vocabulary is also fixed. Refs RIG-2677 Co-authored-by: Matt Wilkinson <matt@rigel.build>
Repair the notification-delivery header grammar, and rewrap the restored lines to their file's column. Cite only OQ-1b for the no-renumber rule, since DL-186 renumbered densely. Refs RIG-2677 Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
marked this pull request as ready for review
September 26, 2026 22:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs RIG-2677.
Pre-GA, nothing is frozen (see the
AGENTS.mdsection "Pre-GA posture: nothing is frozen"). This sweep removes wording that cited frozenness, or a merged half's existence, as the reason for a design choice. Each passage now states the design on its own terms. No decision changes.Scope
docs/designs/{agent,server,ui,infra,meta,platform,repo,observability}anddocs/concepts.compass-proto:gen) and sqlc output regenerated from the edited.protoand query comments.Kept on purpose
DECISIONS.mdis not touched.Excluded
Follow-up
Decisions that rested only on a freeze are listed in RIG-4041 for their own design pass.
Checks
rumdl check: 115 files, clean.go vet(default + pgtest),go build,golangci-lint ./...: 0 issues.go test ./...passes.compass-agent: bun test 726 pass.apps/ui:bun test --conditions browser src/gives 1134 pass / 4 fail, the same as main. The 4 are env-secrecy gate cases that need a.gitdir.compass-proto:drift,compass-go:sqlc-drift, TS typechecks, and the design-ledger gate all pass.Notes for review
path:linecites still resolve.DECISIONS.mdwording verbatim, including "frozen" where the ledger row says it.runner.protoheader and RPC comments verbatim. The records are change-controlled, so those quotes now differ from the source on purpose.