Repository navigation
Fix the ppc64 CI package install - #580
Merged
Merged
Conversation
ubuntu-latest is Ubuntu 26.04, where qemu-system-ppc64 is a virtual package and apt refuses it. The tests run qemu-ppc64, which is in qemu-user. Put that run back on its own line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ppc64 job on master fails while installing QEMU: https://github.com/RoaringBitmap/roaring/actions/runs/40593156613/job/122502261189
ubuntu-latestis Ubuntu 26.04.qemu-system-ppc64is a virtual package there (qemu-system-ppcprovides it), soapt install qemu-system-ppc64exits 100. The tests never start that emulator. They runqemu-ppc64, which is/usr/bin/qemu-ppc64fromqemu-user.The compile of
BitSliceIndexingandqemu-ppc64 ./roaring_testhad also been joined into one shell command, so the root test binary would not have been run after apt succeeded.Type of Change
Changes Made
What was changed?
.github/workflows/bigendiantests.ymlinstallsqemu-userand runsqemu-ppc64 ./roaring_testas its own command.Why was it changed?
qemu-system-ppc64on the current GitHub runner image.How was it changed?
Testing
Workflow-only change. The package name was checked against the Ubuntu 26.04 contents index:
usr/bin/qemu-ppc64isuniverse/misc/qemu-user.Formatting
No Go changes.
Fuzzing
Not run.
Performance Impact
None.
Breaking Changes
None.
Related Issues
Fixes the failure in https://github.com/RoaringBitmap/roaring/actions/runs/40593156613/job/122502261189