Skip to content

ci: approve dependabot PRs so auto-merge can go through - #171

Merged
ruben-arts merged 1 commit into
mainfrom
approve-dependabot-prs-for-auto-merge
Aug 25, 2026
Merged

ci: approve dependabot PRs so auto-merge can go through#171
ruben-arts merged 1 commit into
mainfrom
approve-dependabot-prs-for-auto-merge

Conversation

@Hofer-Julian

Copy link
Copy Markdown
Contributor

The ruleset on main requires one approving review. The auto-merge workflow only enabled auto-merge, so every dependabot PR sat there waiting for a review that never came and I ended up approving them by hand anyway.

  • Approve the PR with gh pr review --approve before enabling auto-merge
  • Move the job into checks.yml and gate it on needs: [checks], so the approval only happens once the build is green
  • Drop dependabot-auto-merge.yml

Major bumps stay excluded, and the actor check stays on github.event.pull_request.user.login instead of github.actor so re-running the workflow myself doesn't turn auto-merge off.

This relies on "Allow GitHub Actions to create and approve pull requests", which is already enabled on the repo.

The ruleset on `main` requires one approving review. The auto-merge workflow only enabled auto-merge, so every dependabot PR sat there waiting for a review that never came and I ended up approving them by hand anyway.

- Approve the PR with `gh pr review --approve` before enabling auto-merge
- Move the job into `checks.yml` and gate it on `needs: [checks]`, so the approval only happens once the build is green
- Drop `dependabot-auto-merge.yml`

Major bumps stay excluded, and the actor check stays on `github.event.pull_request.user.login` instead of `github.actor` so re-running the workflow myself doesn't turn auto-merge off.

This relies on "Allow GitHub Actions to create and approve pull requests", which is already enabled on the repo.
@Hofer-Julian
Hofer-Julian marked this pull request as ready for review August 25, 2026 07:43
@ruben-arts
ruben-arts enabled auto-merge (squash) August 25, 2026 12:06
@ruben-arts
ruben-arts merged commit 0a6fa39 into main Aug 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants