Save cache after cancelled builds - #40
Merged
Merged
Conversation
Allow cache and artifact uploads to retain partial build output when the build step is cancelled, including by the job timeout. Document why skipped builds are excluded.
Member
|
Thanks for the fix! |
traversaro
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my previous PR, #31, I modified the workflow to save the cache only when build-recipes is triggered. However, I forgot to account for the case where build-recipes gets cancelled due to the GitHub Actions timeout.
This caused the issue in #38, where the cache was not saved.
Super sorry about that!