Skip to content

Commit 01eafcc

Browse files
committed
coresight: Discard pm_runtime_put() return values
Failing a debugfs write due to pm_runtime_put() returning a negative value is not particularly useful. Returning an error code from pm_runtime_put() merely means that it has not queued up a work item to check whether or not the device can be suspended and there are many perfectly valid situations in which that can happen, like after writing "on" to the devices' runtime PM "control" attribute in sysfs for one example. It also happens when the kernel has been configured with CONFIG_PM unset, in which case debug_disable_func() in the coresight driver will always return an error. For this reason, update debug_disable_func() to simply discard the return value of pm_runtime_put(), change its return type to void, and propagate that change to debug_func_knob_write(). This will facilitate a planned change of the pm_runtime_put() return type to void in the future. Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com> Link: https://patch.msgid.link/2058657.yKVeVyVuyW@rafael.j.wysocki
1 parent d33976b commit 01eafcc

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

drivers/hwtracing/coresight/coresight-cpu-debug.c

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -451,10 +451,10 @@ static int debug_enable_func(void)
451451
return ret;
452452
}
453453

454-
static int debug_disable_func(void)
454+
static void debug_disable_func(void)
455455
{
456456
struct debug_drvdata *drvdata;
457-
int cpu, ret, err = 0;
457+
int cpu;
458458

459459
/*
460460
* Disable debug power domains, records the error and keep
@@ -466,12 +466,8 @@ static int debug_disable_func(void)
466466
if (!drvdata)
467467
continue;
468468

469-
ret = pm_runtime_put(drvdata->dev);
470-
if (ret < 0)
471-
err = ret;
469+
pm_runtime_put(drvdata->dev);
472470
}
473-
474-
return err;
475471
}
476472

477473
static ssize_t debug_func_knob_write(struct file *f,
@@ -492,7 +488,7 @@ static ssize_t debug_func_knob_write(struct file *f,
492488
if (val)
493489
ret = debug_enable_func();
494490
else
495-
ret = debug_disable_func();
491+
debug_disable_func();
496492

497493
if (ret) {
498494
pr_err("%s: unable to %s debug function: %d\n",

0 commit comments

Comments
 (0)