Skip to content

Commit 0a4606a

Browse files
Uwe Kleine-Königlag-linaro
authored andcommitted
backlight: pwm_bl: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Signed-off-by: Lee Jones <lee@kernel.org> Link: https://lore.kernel.org/r/20230308073945.2336302-11-u.kleine-koenig@pengutronix.de
1 parent 519e5cc commit 0a4606a

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/video/backlight/pwm_bl.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -625,7 +625,7 @@ static int pwm_backlight_probe(struct platform_device *pdev)
625625
return ret;
626626
}
627627

628-
static int pwm_backlight_remove(struct platform_device *pdev)
628+
static void pwm_backlight_remove(struct platform_device *pdev)
629629
{
630630
struct backlight_device *bl = platform_get_drvdata(pdev);
631631
struct pwm_bl_data *pb = bl_get_data(bl);
@@ -635,8 +635,6 @@ static int pwm_backlight_remove(struct platform_device *pdev)
635635

636636
if (pb->exit)
637637
pb->exit(&pdev->dev);
638-
639-
return 0;
640638
}
641639

642640
static void pwm_backlight_shutdown(struct platform_device *pdev)
@@ -690,7 +688,7 @@ static struct platform_driver pwm_backlight_driver = {
690688
.of_match_table = of_match_ptr(pwm_backlight_of_match),
691689
},
692690
.probe = pwm_backlight_probe,
693-
.remove = pwm_backlight_remove,
691+
.remove_new = pwm_backlight_remove,
694692
.shutdown = pwm_backlight_shutdown,
695693
};
696694

0 commit comments

Comments
 (0)