Skip to content

Commit 1242688

Browse files
author
Tzung-Bi Shih
committed
platform/chrome: cros_ec_proto: add Kunit test for cros_ec_map_error()
cros_ec_cmd_xfer_status() is the only exported function that calls static function cros_ec_map_error(). Add Kunit test for cros_ec_map_error() through calling cros_ec_cmd_xfer_status(). Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org> Reviewed-by: Guenter Roeck <groeck@chromium.org> Link: https://lore.kernel.org/r/20220622041040.202737-3-tzungbi@kernel.org
1 parent 74bed42 commit 1242688

1 file changed

Lines changed: 49 additions & 0 deletions

File tree

drivers/platform/chrome/cros_ec_proto_test.c

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2004,6 +2004,54 @@ static void cros_ec_proto_test_cmd_xfer_status_xfer_error(struct kunit *test)
20042004
KUNIT_EXPECT_EQ(test, ret, -EPROTO);
20052005
}
20062006

2007+
static void cros_ec_proto_test_cmd_xfer_status_return_error(struct kunit *test)
2008+
{
2009+
struct cros_ec_proto_test_priv *priv = test->priv;
2010+
struct cros_ec_device *ec_dev = &priv->ec_dev;
2011+
struct ec_xfer_mock *mock;
2012+
int ret, i;
2013+
struct cros_ec_command msg;
2014+
static const int map[] = {
2015+
[EC_RES_SUCCESS] = 0,
2016+
[EC_RES_INVALID_COMMAND] = -EOPNOTSUPP,
2017+
[EC_RES_ERROR] = -EIO,
2018+
[EC_RES_INVALID_PARAM] = -EINVAL,
2019+
[EC_RES_ACCESS_DENIED] = -EACCES,
2020+
[EC_RES_INVALID_RESPONSE] = -EPROTO,
2021+
[EC_RES_INVALID_VERSION] = -ENOPROTOOPT,
2022+
[EC_RES_INVALID_CHECKSUM] = -EBADMSG,
2023+
/*
2024+
* EC_RES_IN_PROGRESS is special because cros_ec_send_command() has extra logic to
2025+
* handle it. Note that default cros_kunit_ec_xfer_mock_default_ret == 0 thus
2026+
* cros_ec_xfer_command() in cros_ec_wait_until_complete() returns 0. As a result,
2027+
* it returns -EPROTO without calling cros_ec_map_error().
2028+
*/
2029+
[EC_RES_IN_PROGRESS] = -EPROTO,
2030+
[EC_RES_UNAVAILABLE] = -ENODATA,
2031+
[EC_RES_TIMEOUT] = -ETIMEDOUT,
2032+
[EC_RES_OVERFLOW] = -EOVERFLOW,
2033+
[EC_RES_INVALID_HEADER] = -EBADR,
2034+
[EC_RES_REQUEST_TRUNCATED] = -EBADR,
2035+
[EC_RES_RESPONSE_TOO_BIG] = -EFBIG,
2036+
[EC_RES_BUS_ERROR] = -EFAULT,
2037+
[EC_RES_BUSY] = -EBUSY,
2038+
[EC_RES_INVALID_HEADER_VERSION] = -EBADMSG,
2039+
[EC_RES_INVALID_HEADER_CRC] = -EBADMSG,
2040+
[EC_RES_INVALID_DATA_CRC] = -EBADMSG,
2041+
[EC_RES_DUP_UNAVAILABLE] = -ENODATA,
2042+
};
2043+
2044+
memset(&msg, 0, sizeof(msg));
2045+
2046+
for (i = 0; i < ARRAY_SIZE(map); ++i) {
2047+
mock = cros_kunit_ec_xfer_mock_addx(test, 0, i, 0);
2048+
KUNIT_ASSERT_PTR_NE(test, mock, NULL);
2049+
2050+
ret = cros_ec_cmd_xfer_status(ec_dev, &msg);
2051+
KUNIT_EXPECT_EQ(test, ret, map[i]);
2052+
}
2053+
}
2054+
20072055
static void cros_ec_proto_test_release(struct device *dev)
20082056
{
20092057
}
@@ -2086,6 +2134,7 @@ static struct kunit_case cros_ec_proto_test_cases[] = {
20862134
KUNIT_CASE(cros_ec_proto_test_cmd_xfer_in_progress_return0),
20872135
KUNIT_CASE(cros_ec_proto_test_cmd_xfer_status_normal),
20882136
KUNIT_CASE(cros_ec_proto_test_cmd_xfer_status_xfer_error),
2137+
KUNIT_CASE(cros_ec_proto_test_cmd_xfer_status_return_error),
20892138
{}
20902139
};
20912140

0 commit comments

Comments
 (0)