Skip to content

Commit 1920aa9

Browse files
Uwe Kleine-Königbebarino
authored andcommitted
clk: axm5516: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230312161512.2715500-8-u.kleine-koenig@pengutronix.de Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 778dc8b commit 1920aa9

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

drivers/clk/clk-axm5516.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -572,15 +572,14 @@ static int axmclk_probe(struct platform_device *pdev)
572572
return of_clk_add_hw_provider(dev->of_node, of_clk_axmclk_get, NULL);
573573
}
574574

575-
static int axmclk_remove(struct platform_device *pdev)
575+
static void axmclk_remove(struct platform_device *pdev)
576576
{
577577
of_clk_del_provider(pdev->dev.of_node);
578-
return 0;
579578
}
580579

581580
static struct platform_driver axmclk_driver = {
582581
.probe = axmclk_probe,
583-
.remove = axmclk_remove,
582+
.remove_new = axmclk_remove,
584583
.driver = {
585584
.name = "clk-axm5516",
586585
.of_match_table = axmclk_match_table,

0 commit comments

Comments
 (0)