Skip to content

Commit 1cf8ddc

Browse files
tombamchehab
authored andcommitted
media: i2c: ds90ub953: Fix use of uninitialized variables
smatch reports some uninitialized variables: drivers/media/i2c/ds90ub953.c:655 ub953_log_status() error: uninitialized symbol 'gpio_local_data'. drivers/media/i2c/ds90ub953.c:655 ub953_log_status() error: uninitialized symbol 'gpio_input_ctrl'. drivers/media/i2c/ds90ub953.c:655 ub953_log_status() error: uninitialized symbol 'gpio_pin_sts'. These are used only for printing debug information, and the use of an uninitialized variable only happens if an i2c transaction has failed, which will print an error. Thus, fix the errors just by initializing the variables to 0. Closes: https://lore.kernel.org/all/8d6daeb1-b62a-bbb2-b840-8759c84f2085@xs4all.nl/ Fixes: 6363db1 ("media: i2c: add DS90UB953 driver") Reported-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
1 parent ea90034 commit 1cf8ddc

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/media/i2c/ds90ub953.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -606,9 +606,9 @@ static int ub953_log_status(struct v4l2_subdev *sd)
606606
u8 v = 0, v1 = 0, v2 = 0;
607607
unsigned int i;
608608
char id[UB953_REG_FPD3_RX_ID_LEN];
609-
u8 gpio_local_data;
610-
u8 gpio_input_ctrl;
611-
u8 gpio_pin_sts;
609+
u8 gpio_local_data = 0;
610+
u8 gpio_input_ctrl = 0;
611+
u8 gpio_pin_sts = 0;
612612

613613
for (i = 0; i < sizeof(id); i++)
614614
ub953_read(priv, UB953_REG_FPD3_RX_ID(i), &id[i]);

0 commit comments

Comments
 (0)