Skip to content

Commit 1df931d

Browse files
jbeulichbonzini
authored andcommitted
x86: drop bogus "cc" clobber from __try_cmpxchg_user_asm()
As noted (and fixed) a couple of times in the past, "=@cc<cond>" outputs and clobbering of "cc" don't work well together. The compiler appears to mean to reject such, but doesn't - in its upstream form - quite manage to yet for "cc". Furthermore two similar macros don't clobber "cc", and clobbering "cc" is pointless in asm()-s for x86 anyway - the compiler always assumes status flags to be clobbered there. Fixes: 989b5db ("x86/uaccess: Implement macros for CMPXCHG on user addresses") Signed-off-by: Jan Beulich <jbeulich@suse.com> Message-Id: <485c0c0b-a3a7-0b7c-5264-7d00c01de032@suse.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
1 parent cf4a869 commit 1df931d

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

arch/x86/include/asm/uaccess.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,7 @@ do { \
439439
[ptr] "+m" (*_ptr), \
440440
[old] "+a" (__old) \
441441
: [new] ltype (__new) \
442-
: "memory", "cc"); \
442+
: "memory"); \
443443
if (unlikely(__err)) \
444444
goto label; \
445445
if (unlikely(!success)) \

0 commit comments

Comments
 (0)