media: pci: tw686x: no need to check 'next'

Hans Verkuil · mchehab · commit 2104793233c2 · 2023-06-09T16:09:10.000+01:00
If 'done' is not NULL, then next can never be NULL, so just drop
the 'next' check.

This fixes this smatch warning:

drivers/media/pci/tw686x/tw686x-audio.c:62 tw686x_audio_irq() warn: can 'next' even be NULL?

Signed-off-by: Hans Verkuil &lt;hverkuil-cisco@xs4all.nl&gt;
Cc: Ezequiel Garcia &lt;ezequiel@vanguardiasur.com.ar&gt;
Signed-off-by: Mauro Carvalho Chehab &lt;mchehab@kernel.org&gt;
diff --git a/drivers/media/pci/tw686x/tw686x-audio.c b/drivers/media/pci/tw686x/tw686x-audio.c
@@ -59,7 +59,7 @@ void tw686x_audio_irq(struct tw686x_dev *dev, unsigned long requests,
 		}
 		spin_unlock_irqrestore(&ac->lock, flags);
 
-		if (!done || !next)
+		if (!done)
 			continue;
 		/*
 		 * Checking for a non-nil dma_desc[pb]->virt buffer is

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ void tw686x_audio_irq(struct tw686x_dev *dev, unsigned long requests,`
`59`	`59`	`}`
`60`	`60`	`spin_unlock_irqrestore(&ac->lock, flags);`
`61`	`61`
`62`		`- if (!done \|\| !next)`
	`62`	`+ if (!done)`
`63`	`63`	`continue;`
`64`	`64`	`/*`
`65`	`65`	`* Checking for a non-nil dma_desc[pb]->virt buffer is`