Skip to content

Commit 21ec672

Browse files
Tian Taosnitm
authored andcommitted
dm writecache: fix unnecessary NULL check warnings
Remove NULL checks before vfree() to fix these warnings: ./drivers/md/dm-writecache.c:2008:2-7: WARNING: NULL check before some freeing functions is not needed. ./drivers/md/dm-writecache.c:2024:2-7: WARNING: NULL check before some freeing functions is not needed. Signed-off-by: Tian Tao <tiantao6@hisilicon.com> Signed-off-by: Mike Snitzer <snitzer@redhat.com>
1 parent cb72848 commit 21ec672

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/md/dm-writecache.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2004,8 +2004,7 @@ static void writecache_dtr(struct dm_target *ti)
20042004
if (wc->ssd_dev)
20052005
dm_put_device(ti, wc->ssd_dev);
20062006

2007-
if (wc->entries)
2008-
vfree(wc->entries);
2007+
vfree(wc->entries);
20092008

20102009
if (wc->memory_map) {
20112010
if (WC_MODE_PMEM(wc))
@@ -2020,8 +2019,7 @@ static void writecache_dtr(struct dm_target *ti)
20202019
if (wc->dm_io)
20212020
dm_io_client_destroy(wc->dm_io);
20222021

2023-
if (wc->dirty_bitmap)
2024-
vfree(wc->dirty_bitmap);
2022+
vfree(wc->dirty_bitmap);
20252023

20262024
kfree(wc);
20272025
}

0 commit comments

Comments
 (0)