Skip to content

Commit 254a4fd

Browse files
committed
fbdev/xen-fbfront: Use struct fb_info.screen_buffer
Use info->screen_buffer when reading and writing framebuffers in system memory. It's the correct pointer for this address space. The struct fb_info has a union to store the framebuffer memory. This can either be info->screen_base if the framebuffer is stored in I/O memory, or info->screen_buffer if the framebuffer is stored in system memory. As the driver operates on the latter address space, it is wrong to use .screen_base and .screen_buffer must be used instead. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230428122452.4856-14-tzimmermann@suse.de
1 parent 5a2c399 commit 254a4fd

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/video/fbdev/xen-fbfront.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,7 @@ static int xenfb_probe(struct xenbus_device *dev,
429429
fb_info->pseudo_palette = fb_info->par;
430430
fb_info->par = info;
431431

432-
fb_info->screen_base = info->fb;
432+
fb_info->screen_buffer = info->fb;
433433

434434
fb_info->fbops = &xenfb_fb_ops;
435435
fb_info->var.xres_virtual = fb_info->var.xres = video[KPARAM_WIDTH];

0 commit comments

Comments
 (0)