hwmon: (gpio-fan) fix sysfs notifications and udev events for gpio-fan alarms

Christian Schneider · groeck · commit 277c628fa5ac · 2019-07-08T18:11:32.000-07:00
sysfs_notify() and kobject_uevent() are passed the wrong device.
fan_data-&gt;hwmon_dev needs to be passed, so that sysfs notification
goes to right place and generated uevent has the right information

Signed-off-by: Christian Schneider &lt;cschneider@radiodata.biz&gt;
Signed-off-by: Guenter Roeck &lt;linux@roeck-us.net&gt;
diff --git a/drivers/hwmon/gpio-fan.c b/drivers/hwmon/gpio-fan.c
@@ -54,8 +54,8 @@ static void fan_alarm_notify(struct work_struct *ws)
 	struct gpio_fan_data *fan_data =
 		container_of(ws, struct gpio_fan_data, alarm_work);
 
-	sysfs_notify(&fan_data->dev->kobj, NULL, "fan1_alarm");
-	kobject_uevent(&fan_data->dev->kobj, KOBJ_CHANGE);
+	sysfs_notify(&fan_data->hwmon_dev->kobj, NULL, "fan1_alarm");
+	kobject_uevent(&fan_data->hwmon_dev->kobj, KOBJ_CHANGE);
 }
 
 static irqreturn_t fan_alarm_irq_handler(int irq, void *dev_id)

Original file line number	Diff line number	Diff line change
`@@ -54,8 +54,8 @@ static void fan_alarm_notify(struct work_struct *ws)`
`54`	`54`	`struct gpio_fan_data *fan_data =`
`55`	`55`	`container_of(ws, struct gpio_fan_data, alarm_work);`
`56`	`56`
`57`		`- sysfs_notify(&fan_data->dev->kobj, NULL, "fan1_alarm");`
`58`		`- kobject_uevent(&fan_data->dev->kobj, KOBJ_CHANGE);`
	`57`	`+ sysfs_notify(&fan_data->hwmon_dev->kobj, NULL, "fan1_alarm");`
	`58`	`+ kobject_uevent(&fan_data->hwmon_dev->kobj, KOBJ_CHANGE);`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`static irqreturn_t fan_alarm_irq_handler(int irq, void *dev_id)`