Skip to content

Commit 298c2af

Browse files
Saravana Kannangregkh
authored andcommitted
drivers: core: fw_devlink: Make the error message a bit more useful
It would make it easier to debugs issues similar to the ones reported[1][2] recently where some devices didn't have the fwnode set. [1] - https://lore.kernel.org/all/7b995947-4540-4b17-872e-e107adca4598@notapiano/ [2] - https://lore.kernel.org/all/20240910130019.35081-1-jonathanh@nvidia.com/ Signed-off-by: Saravana Kannan <saravanak@google.com> Link: https://lore.kernel.org/r/20241024061347.1771063-4-saravanak@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 74ffe43 commit 298c2af

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/base/core.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2173,8 +2173,8 @@ static int fw_devlink_create_devlink(struct device *con,
21732173
}
21742174

21752175
if (con != sup_dev && !device_link_add(con, sup_dev, flags)) {
2176-
dev_err(con, "Failed to create device link (0x%x) with %s\n",
2177-
flags, dev_name(sup_dev));
2176+
dev_err(con, "Failed to create device link (0x%x) with supplier %s for %pfwf\n",
2177+
flags, dev_name(sup_dev), link->consumer);
21782178
ret = -EINVAL;
21792179
}
21802180

0 commit comments

Comments
 (0)