Skip to content

Commit 2a1297e

Browse files
Marek Vasutbjorn-helgaas
authored andcommitted
PCI: mobiveil: Silence 'set affinity failed' warning
Use MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity() unset and allows migrate_one_irq() to exit right away, without warnings like this: IRQ...: set affinity failed(-22) Remove the .irq_set_affinity() implementation that is no longer needed. Link: https://lore.kernel.org/r/20240723132958.41320-9-marek.vasut+renesas@mailbox.org Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> [bhelgaas: commit log] Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Acked-by: Thomas Gleixner <tglx@linutronix.de>
1 parent 63e4794 commit 2a1297e

1 file changed

Lines changed: 2 additions & 9 deletions

File tree

drivers/pci/controller/mobiveil/pcie-mobiveil-host.c

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -360,8 +360,8 @@ static struct irq_chip mobiveil_msi_irq_chip = {
360360
};
361361

362362
static struct msi_domain_info mobiveil_msi_domain_info = {
363-
.flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
364-
MSI_FLAG_PCI_MSIX),
363+
.flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
364+
MSI_FLAG_NO_AFFINITY | MSI_FLAG_PCI_MSIX,
365365
.chip = &mobiveil_msi_irq_chip,
366366
};
367367

@@ -378,16 +378,9 @@ static void mobiveil_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
378378
(int)data->hwirq, msg->address_hi, msg->address_lo);
379379
}
380380

381-
static int mobiveil_msi_set_affinity(struct irq_data *irq_data,
382-
const struct cpumask *mask, bool force)
383-
{
384-
return -EINVAL;
385-
}
386-
387381
static struct irq_chip mobiveil_msi_bottom_irq_chip = {
388382
.name = "Mobiveil MSI",
389383
.irq_compose_msi_msg = mobiveil_compose_msi_msg,
390-
.irq_set_affinity = mobiveil_msi_set_affinity,
391384
};
392385

393386
static int mobiveil_irq_msi_domain_alloc(struct irq_domain *domain,

0 commit comments

Comments
 (0)