Skip to content

Commit 63e4794

Browse files
Marek Vasutbjorn-helgaas
authored andcommitted
PCI: mediatek: Silence 'set affinity failed' warning
Use MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity() unset and allows migrate_one_irq() to exit right away, without warnings like this: IRQ...: set affinity failed(-22) Remove the .irq_set_affinity() implementation that is no longer needed. Link: https://lore.kernel.org/r/20240723132958.41320-8-marek.vasut+renesas@mailbox.org Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> [bhelgaas: commit log] Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Acked-by: Jianjun Wang <jianjun.wang@mediatek.com> Acked-by: Thomas Gleixner <tglx@linutronix.de>
1 parent 425c075 commit 63e4794

1 file changed

Lines changed: 2 additions & 9 deletions

File tree

drivers/pci/controller/pcie-mediatek.c

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -407,12 +407,6 @@ static void mtk_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
407407
(int)data->hwirq, msg->address_hi, msg->address_lo);
408408
}
409409

410-
static int mtk_msi_set_affinity(struct irq_data *irq_data,
411-
const struct cpumask *mask, bool force)
412-
{
413-
return -EINVAL;
414-
}
415-
416410
static void mtk_msi_ack_irq(struct irq_data *data)
417411
{
418412
struct mtk_pcie_port *port = irq_data_get_irq_chip_data(data);
@@ -424,7 +418,6 @@ static void mtk_msi_ack_irq(struct irq_data *data)
424418
static struct irq_chip mtk_msi_bottom_irq_chip = {
425419
.name = "MTK MSI",
426420
.irq_compose_msi_msg = mtk_compose_msi_msg,
427-
.irq_set_affinity = mtk_msi_set_affinity,
428421
.irq_ack = mtk_msi_ack_irq,
429422
};
430423

@@ -486,8 +479,8 @@ static struct irq_chip mtk_msi_irq_chip = {
486479
};
487480

488481
static struct msi_domain_info mtk_msi_domain_info = {
489-
.flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
490-
MSI_FLAG_PCI_MSIX),
482+
.flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
483+
MSI_FLAG_NO_AFFINITY | MSI_FLAG_PCI_MSIX,
491484
.chip = &mtk_msi_irq_chip,
492485
};
493486

0 commit comments

Comments
 (0)