Skip to content

Commit 2b04bd4

Browse files
YuuoniyPaolo Abeni
authored andcommitted
dpaa2-ptp: Fix refcount leak in dpaa2_ptp_probe
This node pointer is returned by of_find_compatible_node() with refcount incremented. Calling of_node_put() to aovid the refcount leak. Fixes: d346c9e ("dpaa2-ptp: reuse ptp_qoriq driver") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Link: https://lore.kernel.org/r/20220404125336.13427-1-linmq006@gmail.com Signed-off-by: Paolo Abeni <pabeni@redhat.com>
1 parent e3d3721 commit 2b04bd4

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/net/ethernet/freescale/dpaa2/dpaa2-ptp.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ static int dpaa2_ptp_probe(struct fsl_mc_device *mc_dev)
167167
base = of_iomap(node, 0);
168168
if (!base) {
169169
err = -ENOMEM;
170-
goto err_close;
170+
goto err_put;
171171
}
172172

173173
err = fsl_mc_allocate_irqs(mc_dev);
@@ -210,6 +210,8 @@ static int dpaa2_ptp_probe(struct fsl_mc_device *mc_dev)
210210
fsl_mc_free_irqs(mc_dev);
211211
err_unmap:
212212
iounmap(base);
213+
err_put:
214+
of_node_put(node);
213215
err_close:
214216
dprtc_close(mc_dev->mc_io, 0, mc_dev->mc_handle);
215217
err_free_mcp:

0 commit comments

Comments
 (0)