Skip to content

Commit 34014ff

Browse files
Uwe Kleine-Königbebarino
authored andcommitted
clk: s2mps11: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230312161512.2715500-15-u.kleine-koenig@pengutronix.de Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent e72cdad commit 34014ff

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/clk/clk-s2mps11.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ static int s2mps11_clk_probe(struct platform_device *pdev)
202202
return ret;
203203
}
204204

205-
static int s2mps11_clk_remove(struct platform_device *pdev)
205+
static void s2mps11_clk_remove(struct platform_device *pdev)
206206
{
207207
struct s2mps11_clk *s2mps11_clks = platform_get_drvdata(pdev);
208208
int i;
@@ -217,8 +217,6 @@ static int s2mps11_clk_remove(struct platform_device *pdev)
217217
continue;
218218
clkdev_drop(s2mps11_clks[i].lookup);
219219
}
220-
221-
return 0;
222220
}
223221

224222
static const struct platform_device_id s2mps11_clk_id[] = {
@@ -265,7 +263,7 @@ static struct platform_driver s2mps11_clk_driver = {
265263
.name = "s2mps11-clk",
266264
},
267265
.probe = s2mps11_clk_probe,
268-
.remove = s2mps11_clk_remove,
266+
.remove_new = s2mps11_clk_remove,
269267
.id_table = s2mps11_clk_id,
270268
};
271269
module_platform_driver(s2mps11_clk_driver);

0 commit comments

Comments
 (0)