Skip to content

Commit e72cdad

Browse files
Uwe Kleine-Königbebarino
authored andcommitted
clk: pwm: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230312161512.2715500-14-u.kleine-koenig@pengutronix.de Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 8ffd6c2 commit e72cdad

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/clk/clk-pwm.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,11 +129,9 @@ static int clk_pwm_probe(struct platform_device *pdev)
129129
return of_clk_add_hw_provider(node, of_clk_hw_simple_get, &clk_pwm->hw);
130130
}
131131

132-
static int clk_pwm_remove(struct platform_device *pdev)
132+
static void clk_pwm_remove(struct platform_device *pdev)
133133
{
134134
of_clk_del_provider(pdev->dev.of_node);
135-
136-
return 0;
137135
}
138136

139137
static const struct of_device_id clk_pwm_dt_ids[] = {
@@ -144,7 +142,7 @@ MODULE_DEVICE_TABLE(of, clk_pwm_dt_ids);
144142

145143
static struct platform_driver clk_pwm_driver = {
146144
.probe = clk_pwm_probe,
147-
.remove = clk_pwm_remove,
145+
.remove_new = clk_pwm_remove,
148146
.driver = {
149147
.name = "pwm-clock",
150148
.of_match_table = clk_pwm_dt_ids,

0 commit comments

Comments
 (0)