Skip to content

Commit 373a34a

Browse files
author
Paolo Abeni
committed
Merge branch 'there-are-some-bugfix-for-the-hns3-ethernet-driver'
Jijie Shao says: ==================== There are some bugfix for the HNS3 ethernet driver ==================== Link: https://patch.msgid.link/20251211023737.2327018-1-shaojijie@huawei.com Signed-off-by: Paolo Abeni <pabeni@redhat.com>
2 parents 2939203 + 6ef935e commit 373a34a

3 files changed

Lines changed: 7 additions & 4 deletions

File tree

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10555,6 +10555,9 @@ int hclge_set_vlan_filter(struct hnae3_handle *handle, __be16 proto,
1055510555
bool writen_to_tbl = false;
1055610556
int ret = 0;
1055710557

10558+
if (vlan_id >= VLAN_N_VID)
10559+
return -EINVAL;
10560+
1055810561
/* When device is resetting or reset failed, firmware is unable to
1055910562
* handle mailbox. Just record the vlan id, and remove it after
1056010563
* reset finished.

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,10 +193,10 @@ static int hclge_get_ring_chain_from_mbx(
193193
return -EINVAL;
194194

195195
for (i = 0; i < ring_num; i++) {
196-
if (req->msg.param[i].tqp_index >= vport->nic.kinfo.rss_size) {
196+
if (req->msg.param[i].tqp_index >= vport->nic.kinfo.num_tqps) {
197197
dev_err(&hdev->pdev->dev, "tqp index(%u) is out of range(0-%u)\n",
198198
req->msg.param[i].tqp_index,
199-
vport->nic.kinfo.rss_size - 1U);
199+
vport->nic.kinfo.num_tqps - 1U);
200200
return -EINVAL;
201201
}
202202
}

drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -368,12 +368,12 @@ static int hclgevf_knic_setup(struct hclgevf_dev *hdev)
368368
new_tqps = kinfo->rss_size * num_tc;
369369
kinfo->num_tqps = min(new_tqps, hdev->num_tqps);
370370

371-
kinfo->tqp = devm_kcalloc(&hdev->pdev->dev, kinfo->num_tqps,
371+
kinfo->tqp = devm_kcalloc(&hdev->pdev->dev, hdev->num_tqps,
372372
sizeof(struct hnae3_queue *), GFP_KERNEL);
373373
if (!kinfo->tqp)
374374
return -ENOMEM;
375375

376-
for (i = 0; i < kinfo->num_tqps; i++) {
376+
for (i = 0; i < hdev->num_tqps; i++) {
377377
hdev->htqp[i].q.handle = &hdev->nic;
378378
hdev->htqp[i].q.tqp_index = i;
379379
kinfo->tqp[i] = &hdev->htqp[i].q;

0 commit comments

Comments
 (0)