Skip to content

Commit 415aad7

Browse files
lweiss-fairphoneandersson
authored andcommitted
clk: qcom: camcc-sm7150: Fix PLL config of PLL2
The 'Agera' PLLs (with clk_agera_pll_configure) do not take some of the parameters that are provided in the vendor driver. Instead the upstream configuration should provide the final user_ctl value that is written to the USER_CTL register. Fix the config so that the PLL is configured correctly. Fixes: 9f0532d ("clk: qcom: Add Camera Clock Controller driver for SM7150") Suggested-by: Taniya Das <taniya.das@oss.qualcomm.com> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> Reviewed-by: Abel Vesa <abel.vesa@linaro.org> Reviewed-by: Taniya Das <taniya.das@oss.qualcomm.com> Link: https://lore.kernel.org/r/20251021-agera-pll-fixups-v1-2-8c1d8aff4afc@fairphone.com Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent ab0e131 commit 415aad7

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

drivers/clk/qcom/camcc-sm7150.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -139,13 +139,9 @@ static struct clk_fixed_factor camcc_pll1_out_even = {
139139
/* 1920MHz configuration */
140140
static const struct alpha_pll_config camcc_pll2_config = {
141141
.l = 0x64,
142-
.post_div_val = 0x3 << 8,
143-
.post_div_mask = 0x3 << 8,
144-
.early_output_mask = BIT(3),
145-
.aux_output_mask = BIT(1),
146-
.main_output_mask = BIT(0),
147142
.config_ctl_hi_val = 0x400003d6,
148143
.config_ctl_val = 0x20000954,
144+
.user_ctl_val = 0x0000030b,
149145
};
150146

151147
static struct clk_alpha_pll camcc_pll2 = {

0 commit comments

Comments
 (0)