Skip to content

Commit 4a4027f

Browse files
kubalewskianguy11
authored andcommitted
ice: dpll: fix check for dpll input priority range
Supported priority value for input pins may differ with regard of NIC firmware version. E810T NICs with 3.20/4.00 FW versions would accept priority range 0-31, where firmware 4.10+ would support the range 0-9 and extra value of 255. Remove the in-range check as the driver has no information on supported values from the running firmware, let firmware decide if given value is correct and return extack error if the value is not supported. Fixes: d7999f5 ("ice: implement dpll interface to control cgu") Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com> Tested-by: Sunitha Mekala <sunithax.d.mekala@intel.com> (A Contingent worker at Intel) Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
1 parent 7a1aba8 commit 4a4027f

2 files changed

Lines changed: 0 additions & 7 deletions

File tree

drivers/net/ethernet/intel/ice/ice_dpll.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -815,12 +815,6 @@ ice_dpll_input_prio_set(const struct dpll_pin *pin, void *pin_priv,
815815
struct ice_pf *pf = d->pf;
816816
int ret;
817817

818-
if (prio > ICE_DPLL_PRIO_MAX) {
819-
NL_SET_ERR_MSG_FMT(extack, "prio out of supported range 0-%d",
820-
ICE_DPLL_PRIO_MAX);
821-
return -EINVAL;
822-
}
823-
824818
mutex_lock(&pf->dplls.lock);
825819
ret = ice_dpll_hw_input_prio_set(pf, d, p, prio, extack);
826820
mutex_unlock(&pf->dplls.lock);

drivers/net/ethernet/intel/ice/ice_dpll.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
#include "ice.h"
88

9-
#define ICE_DPLL_PRIO_MAX 0xF
109
#define ICE_DPLL_RCLK_NUM_MAX 4
1110

1211
/** ice_dpll_pin - store info about pins

0 commit comments

Comments
 (0)