Skip to content

Commit 4b83b78

Browse files
arndbmripard
authored andcommitted
drm/imagination: move update_logtype() into ifdef section
This function is only used when debugfs is enabled, and otherwise causes a build warning: drivers/gpu/drm/imagination/pvr_fw_trace.c:135:1: error: 'update_logtype' defined but not used [-Werror=unused-function] Move the #ifdef check to include this function as well. Fixes: cb56cd6 ("drm/imagination: Add firmware trace to debugfs") Acked-by: Frank Binns <frank.binns@imgtec.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de> Link: https://lore.kernel.org/r/20231204073231.1164163-1-arnd@kernel.org Signed-off-by: Maxime Ripard <mripard@kernel.org>
1 parent e9d5ae8 commit 4b83b78

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/gpu/drm/imagination/pvr_fw_trace.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,8 @@ void pvr_fw_trace_fini(struct pvr_device *pvr_dev)
121121
pvr_fw_object_unmap_and_destroy(fw_trace->tracebuf_ctrl_obj);
122122
}
123123

124+
#if defined(CONFIG_DEBUG_FS)
125+
124126
/**
125127
* update_logtype() - Send KCCB command to trigger FW to update logtype
126128
* @pvr_dev: Target PowerVR device
@@ -165,8 +167,6 @@ update_logtype(struct pvr_device *pvr_dev, u32 group_mask)
165167
return err;
166168
}
167169

168-
#if defined(CONFIG_DEBUG_FS)
169-
170170
struct pvr_fw_trace_seq_data {
171171
/** @buffer: Pointer to copy of trace data. */
172172
u32 *buffer;

0 commit comments

Comments
 (0)