Skip to content

Commit 4ee998b

Browse files
committed
Merge tag 'clk-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux
Pull clk fixes from Stephen Boyd: "Three fixes for the Qualcomm clk driver: two for regressions this merge window and one for a long-standing problem that only popped up now that eMMC is being used" * tag 'clk-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux: clk: qcom: gcc-sc7180: Use floor ops for the correct sdcc1 clk clk: qcom: rcg2: Rectify clk_gfx3d rate rounding without mux division clk: qcom: rpmh: Update the XO clock source for SC7280
2 parents a0a4df6 + 148ddaa commit 4ee998b

3 files changed

Lines changed: 16 additions & 12 deletions

File tree

drivers/clk/qcom/clk-rcg2.c

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -730,7 +730,8 @@ static int clk_gfx3d_determine_rate(struct clk_hw *hw,
730730
struct clk_rate_request parent_req = { };
731731
struct clk_rcg2_gfx3d *cgfx = to_clk_rcg2_gfx3d(hw);
732732
struct clk_hw *xo, *p0, *p1, *p2;
733-
unsigned long request, p0_rate;
733+
unsigned long p0_rate;
734+
u8 mux_div = cgfx->div;
734735
int ret;
735736

736737
p0 = cgfx->hws[0];
@@ -750,22 +751,23 @@ static int clk_gfx3d_determine_rate(struct clk_hw *hw,
750751
return 0;
751752
}
752753

753-
request = req->rate;
754-
if (cgfx->div > 1)
755-
parent_req.rate = request = request * cgfx->div;
754+
if (mux_div == 0)
755+
mux_div = 1;
756+
757+
parent_req.rate = req->rate * mux_div;
756758

757759
/* This has to be a fixed rate PLL */
758760
p0_rate = clk_hw_get_rate(p0);
759761

760-
if (request == p0_rate) {
762+
if (parent_req.rate == p0_rate) {
761763
req->rate = req->best_parent_rate = p0_rate;
762764
req->best_parent_hw = p0;
763765
return 0;
764766
}
765767

766768
if (req->best_parent_hw == p0) {
767769
/* Are we going back to a previously used rate? */
768-
if (clk_hw_get_rate(p2) == request)
770+
if (clk_hw_get_rate(p2) == parent_req.rate)
769771
req->best_parent_hw = p2;
770772
else
771773
req->best_parent_hw = p1;
@@ -780,8 +782,7 @@ static int clk_gfx3d_determine_rate(struct clk_hw *hw,
780782
return ret;
781783

782784
req->rate = req->best_parent_rate = parent_req.rate;
783-
if (cgfx->div > 1)
784-
req->rate /= cgfx->div;
785+
req->rate /= mux_div;
785786

786787
return 0;
787788
}

drivers/clk/qcom/clk-rpmh.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -510,9 +510,12 @@ static const struct clk_rpmh_desc clk_rpmh_sm8350 = {
510510
.num_clks = ARRAY_SIZE(sm8350_rpmh_clocks),
511511
};
512512

513+
/* Resource name must match resource id present in cmd-db */
514+
DEFINE_CLK_RPMH_ARC(sc7280, bi_tcxo, bi_tcxo_ao, "xo.lvl", 0x3, 4);
515+
513516
static struct clk_hw *sc7280_rpmh_clocks[] = {
514-
[RPMH_CXO_CLK] = &sdm845_bi_tcxo.hw,
515-
[RPMH_CXO_CLK_A] = &sdm845_bi_tcxo_ao.hw,
517+
[RPMH_CXO_CLK] = &sc7280_bi_tcxo.hw,
518+
[RPMH_CXO_CLK_A] = &sc7280_bi_tcxo_ao.hw,
516519
[RPMH_LN_BB_CLK2] = &sdm845_ln_bb_clk2.hw,
517520
[RPMH_LN_BB_CLK2_A] = &sdm845_ln_bb_clk2_ao.hw,
518521
[RPMH_RF_CLK1] = &sdm845_rf_clk1.hw,

drivers/clk/qcom/gcc-sc7180.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -620,7 +620,7 @@ static struct clk_rcg2 gcc_sdcc1_apps_clk_src = {
620620
.name = "gcc_sdcc1_apps_clk_src",
621621
.parent_data = gcc_parent_data_1,
622622
.num_parents = 5,
623-
.ops = &clk_rcg2_ops,
623+
.ops = &clk_rcg2_floor_ops,
624624
},
625625
};
626626

@@ -642,7 +642,7 @@ static struct clk_rcg2 gcc_sdcc1_ice_core_clk_src = {
642642
.name = "gcc_sdcc1_ice_core_clk_src",
643643
.parent_data = gcc_parent_data_0,
644644
.num_parents = 4,
645-
.ops = &clk_rcg2_floor_ops,
645+
.ops = &clk_rcg2_ops,
646646
},
647647
};
648648

0 commit comments

Comments
 (0)