Skip to content

Commit 51023cf

Browse files
cristiccvinodkoul
authored andcommitted
phy: rockchip: samsung-hdptx: Prevent Inter-Pair Skew from exceeding the limits
Fixup PHY deskew FIFO to prevent the phase of D2 lane going ahead of other lanes. It's worth noting this might only happen when dealing with HDMI 2.0 rates. Fixes: 553be28 ("phy: rockchip: Add Samsung HDMI/eDP Combo PHY driver") Co-developed-by: Algea Cao <algea.cao@rock-chips.com> Signed-off-by: Algea Cao <algea.cao@rock-chips.com> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://patch.msgid.link/20251028-phy-hdptx-fixes-v1-3-ecc642a59d94@collabora.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 8daaced commit 51023cf

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -668,13 +668,9 @@ static const struct reg_sequence rk_hdtpx_common_lane_init_seq[] = {
668668

669669
static const struct reg_sequence rk_hdtpx_tmds_lane_init_seq[] = {
670670
REG_SEQ0(LANE_REG(0312), 0x00),
671-
REG_SEQ0(LANE_REG(031e), 0x00),
672671
REG_SEQ0(LANE_REG(0412), 0x00),
673-
REG_SEQ0(LANE_REG(041e), 0x00),
674672
REG_SEQ0(LANE_REG(0512), 0x00),
675-
REG_SEQ0(LANE_REG(051e), 0x00),
676673
REG_SEQ0(LANE_REG(0612), 0x00),
677-
REG_SEQ0(LANE_REG(061e), 0x08),
678674
REG_SEQ0(LANE_REG(0303), 0x2f),
679675
REG_SEQ0(LANE_REG(0403), 0x2f),
680676
REG_SEQ0(LANE_REG(0503), 0x2f),
@@ -687,6 +683,11 @@ static const struct reg_sequence rk_hdtpx_tmds_lane_init_seq[] = {
687683
REG_SEQ0(LANE_REG(0406), 0x1c),
688684
REG_SEQ0(LANE_REG(0506), 0x1c),
689685
REG_SEQ0(LANE_REG(0606), 0x1c),
686+
/* Keep Inter-Pair Skew in the limits */
687+
REG_SEQ0(LANE_REG(031e), 0x02),
688+
REG_SEQ0(LANE_REG(041e), 0x02),
689+
REG_SEQ0(LANE_REG(051e), 0x02),
690+
REG_SEQ0(LANE_REG(061e), 0x0a),
690691
};
691692

692693
static struct tx_drv_ctrl tx_drv_ctrl_rbr[4][4] = {

0 commit comments

Comments
 (0)