Skip to content

Commit 8daaced

Browse files
cristiccvinodkoul
authored andcommitted
phy: rockchip: samsung-hdptx: Reduce ROPLL loop bandwidth
Due to its relatively low frequency, a noise stemming from the 24MHz PLL reference clock may traverse the low-pass loop filter of ROPLL, which could potentially generate some HDMI flash artifacts. Reduce ROPLL loop bandwidth in an attempt to mitigate the problem. Fixes: 553be28 ("phy: rockchip: Add Samsung HDMI/eDP Combo PHY driver") Co-developed-by: Algea Cao <algea.cao@rock-chips.com> Signed-off-by: Algea Cao <algea.cao@rock-chips.com> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://patch.msgid.link/20251028-phy-hdptx-fixes-v1-2-ecc642a59d94@collabora.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 72126e9 commit 8daaced

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -500,9 +500,7 @@ static const struct reg_sequence rk_hdtpx_common_cmn_init_seq[] = {
500500
REG_SEQ0(CMN_REG(0043), 0x00),
501501
REG_SEQ0(CMN_REG(0044), 0x46),
502502
REG_SEQ0(CMN_REG(0045), 0x24),
503-
REG_SEQ0(CMN_REG(0046), 0xff),
504503
REG_SEQ0(CMN_REG(0047), 0x00),
505-
REG_SEQ0(CMN_REG(0048), 0x44),
506504
REG_SEQ0(CMN_REG(0049), 0xfa),
507505
REG_SEQ0(CMN_REG(004a), 0x08),
508506
REG_SEQ0(CMN_REG(004b), 0x00),
@@ -575,6 +573,8 @@ static const struct reg_sequence rk_hdtpx_tmds_cmn_init_seq[] = {
575573
REG_SEQ0(CMN_REG(0034), 0x00),
576574
REG_SEQ0(CMN_REG(003d), 0x40),
577575
REG_SEQ0(CMN_REG(0042), 0x78),
576+
REG_SEQ0(CMN_REG(0046), 0xdd),
577+
REG_SEQ0(CMN_REG(0048), 0x11),
578578
REG_SEQ0(CMN_REG(004e), 0x34),
579579
REG_SEQ0(CMN_REG(005c), 0x25),
580580
REG_SEQ0(CMN_REG(005e), 0x4f),

0 commit comments

Comments
 (0)