Skip to content

Commit 560a316

Browse files
Jakob-Koschelbebarino
authored andcommitted
clk: ti: clkctrl: replace usage of found with dedicated list iterator variable
To move the list iterator variable into the list_for_each_entry_*() macro in the future it should be avoided to use the list iterator variable after the loop body. To *never* use the list iterator variable after the loop it was concluded to use a separate iterator variable instead of a found boolean [1]. This removes the need to use a found variable and simply checking if the variable was set, can determine if the break/goto was hit. Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com> Link: https://lore.kernel.org/r/20220324071019.59483-1-jakobkoschel@gmail.com Tested-by: Tony Lindgren <tony@atomide.com> Reviewed-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 37004db commit 560a316

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

drivers/clk/ti/clkctrl.c

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -232,24 +232,23 @@ static struct clk_hw *_ti_omap4_clkctrl_xlate(struct of_phandle_args *clkspec,
232232
void *data)
233233
{
234234
struct omap_clkctrl_provider *provider = data;
235-
struct omap_clkctrl_clk *entry;
236-
bool found = false;
235+
struct omap_clkctrl_clk *entry = NULL, *iter;
237236

238237
if (clkspec->args_count != 2)
239238
return ERR_PTR(-EINVAL);
240239

241240
pr_debug("%s: looking for %x:%x\n", __func__,
242241
clkspec->args[0], clkspec->args[1]);
243242

244-
list_for_each_entry(entry, &provider->clocks, node) {
245-
if (entry->reg_offset == clkspec->args[0] &&
246-
entry->bit_offset == clkspec->args[1]) {
247-
found = true;
243+
list_for_each_entry(iter, &provider->clocks, node) {
244+
if (iter->reg_offset == clkspec->args[0] &&
245+
iter->bit_offset == clkspec->args[1]) {
246+
entry = iter;
248247
break;
249248
}
250249
}
251250

252-
if (!found)
251+
if (!entry)
253252
return ERR_PTR(-EINVAL);
254253

255254
return entry->clk;

0 commit comments

Comments
 (0)