Skip to content

Commit 57c05a6

Browse files
Uwe Kleine-Königmathieupoirier
authored andcommitted
remoteproc: qcom_q6v5_pas: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org> Link: https://lore.kernel.org/r/20230504194453.1150368-12-u.kleine-koenig@pengutronix.de Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
1 parent a5f813e commit 57c05a6

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/remoteproc/qcom_q6v5_pas.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -754,7 +754,7 @@ static int adsp_probe(struct platform_device *pdev)
754754
return ret;
755755
}
756756

757-
static int adsp_remove(struct platform_device *pdev)
757+
static void adsp_remove(struct platform_device *pdev)
758758
{
759759
struct qcom_adsp *adsp = platform_get_drvdata(pdev);
760760

@@ -769,8 +769,6 @@ static int adsp_remove(struct platform_device *pdev)
769769
adsp_pds_detach(adsp, adsp->proxy_pds, adsp->proxy_pd_count);
770770
device_init_wakeup(adsp->dev, false);
771771
rproc_free(adsp->rproc);
772-
773-
return 0;
774772
}
775773

776774
static const struct adsp_data adsp_resource_init = {
@@ -1232,7 +1230,7 @@ MODULE_DEVICE_TABLE(of, adsp_of_match);
12321230

12331231
static struct platform_driver adsp_driver = {
12341232
.probe = adsp_probe,
1235-
.remove = adsp_remove,
1233+
.remove_new = adsp_remove,
12361234
.driver = {
12371235
.name = "qcom_q6v5_pas",
12381236
.of_match_table = adsp_of_match,

0 commit comments

Comments
 (0)