Skip to content

Commit 57d1992

Browse files
Marek Vasutbjorn-helgaas
authored andcommitted
PCI: rcar-host: Silence 'set affinity failed' warning
Use MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity() unset and allows migrate_one_irq() to exit right away, without warnings like this: IRQ...: set affinity failed(-22) Remove the .irq_set_affinity() implementation that is no longer needed. Link: https://lore.kernel.org/r/20240723132958.41320-11-marek.vasut+renesas@mailbox.org Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> [bhelgaas: commit log] Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Acked-by: Thomas Gleixner <tglx@linutronix.de>
1 parent e934aba commit 57d1992

1 file changed

Lines changed: 2 additions & 8 deletions

File tree

drivers/pci/controller/pcie-rcar-host.c

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -658,11 +658,6 @@ static void rcar_msi_irq_unmask(struct irq_data *d)
658658
spin_unlock_irqrestore(&msi->mask_lock, flags);
659659
}
660660

661-
static int rcar_msi_set_affinity(struct irq_data *d, const struct cpumask *mask, bool force)
662-
{
663-
return -EINVAL;
664-
}
665-
666661
static void rcar_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
667662
{
668663
struct rcar_msi *msi = irq_data_get_irq_chip_data(data);
@@ -678,7 +673,6 @@ static struct irq_chip rcar_msi_bottom_chip = {
678673
.irq_ack = rcar_msi_irq_ack,
679674
.irq_mask = rcar_msi_irq_mask,
680675
.irq_unmask = rcar_msi_irq_unmask,
681-
.irq_set_affinity = rcar_msi_set_affinity,
682676
.irq_compose_msi_msg = rcar_compose_msi_msg,
683677
};
684678

@@ -725,8 +719,8 @@ static const struct irq_domain_ops rcar_msi_domain_ops = {
725719
};
726720

727721
static struct msi_domain_info rcar_msi_info = {
728-
.flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
729-
MSI_FLAG_MULTI_PCI_MSI),
722+
.flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
723+
MSI_FLAG_NO_AFFINITY | MSI_FLAG_MULTI_PCI_MSI,
730724
.chip = &rcar_msi_top_chip,
731725
};
732726

0 commit comments

Comments
 (0)