Skip to content

Commit e934aba

Browse files
Marek Vasutbjorn-helgaas
authored andcommitted
PCI: plda: Silence 'set affinity failed' warning
Use MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity() unset and allows migrate_one_irq() to exit right away, without warnings like this: IRQ...: set affinity failed(-22) Remove the .irq_set_affinity() implementation that is no longer needed. Link: https://lore.kernel.org/r/20240723132958.41320-10-marek.vasut+renesas@mailbox.org Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> [bhelgaas: commit log] Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Acked-by: Thomas Gleixner <tglx@linutronix.de>
1 parent 2a1297e commit e934aba

1 file changed

Lines changed: 2 additions & 9 deletions

File tree

drivers/pci/controller/plda/pcie-plda-host.c

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -76,17 +76,10 @@ static void plda_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
7676
(int)data->hwirq, msg->address_hi, msg->address_lo);
7777
}
7878

79-
static int plda_msi_set_affinity(struct irq_data *irq_data,
80-
const struct cpumask *mask, bool force)
81-
{
82-
return -EINVAL;
83-
}
84-
8579
static struct irq_chip plda_msi_bottom_irq_chip = {
8680
.name = "PLDA MSI",
8781
.irq_ack = plda_msi_bottom_irq_ack,
8882
.irq_compose_msi_msg = plda_compose_msi_msg,
89-
.irq_set_affinity = plda_msi_set_affinity,
9083
};
9184

9285
static int plda_irq_msi_domain_alloc(struct irq_domain *domain,
@@ -146,8 +139,8 @@ static struct irq_chip plda_msi_irq_chip = {
146139
};
147140

148141
static struct msi_domain_info plda_msi_domain_info = {
149-
.flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
150-
MSI_FLAG_PCI_MSIX),
142+
.flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
143+
MSI_FLAG_NO_AFFINITY | MSI_FLAG_PCI_MSIX,
151144
.chip = &plda_msi_irq_chip,
152145
};
153146

0 commit comments

Comments
 (0)