Skip to content

Commit 5892291

Browse files
Taniya Dasandersson
authored andcommitted
clk: qcom: clk-rcg2: Update logic to calculate D value for RCG
The display pixel clock has a requirement on certain newer platforms to support M/N as (2/3) and the final D value calculated results in underflow errors. As the current implementation does not check for D value is within the accepted range for a given M & N value. Update the logic to calculate the final D value based on the range. Fixes: 99cbd06 ("clk: qcom: Support display RCG clocks") Signed-off-by: Taniya Das <tdas@codeaurora.org> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Link: https://lore.kernel.org/r/20220227175536.3131-1-tdas@codeaurora.org
1 parent 89f0f1a commit 5892291

1 file changed

Lines changed: 11 additions & 2 deletions

File tree

drivers/clk/qcom/clk-rcg2.c

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ static int clk_rcg2_determine_floor_rate(struct clk_hw *hw,
264264

265265
static int __clk_rcg2_configure(struct clk_rcg2 *rcg, const struct freq_tbl *f)
266266
{
267-
u32 cfg, mask;
267+
u32 cfg, mask, d_val, not2d_val, n_minus_m;
268268
struct clk_hw *hw = &rcg->clkr.hw;
269269
int ret, index = qcom_find_src_index(hw, rcg->parent_map, f->src);
270270

@@ -283,8 +283,17 @@ static int __clk_rcg2_configure(struct clk_rcg2 *rcg, const struct freq_tbl *f)
283283
if (ret)
284284
return ret;
285285

286+
/* Calculate 2d value */
287+
d_val = f->n;
288+
289+
n_minus_m = f->n - f->m;
290+
n_minus_m *= 2;
291+
292+
d_val = clamp_t(u32, d_val, f->m, n_minus_m);
293+
not2d_val = ~d_val & mask;
294+
286295
ret = regmap_update_bits(rcg->clkr.regmap,
287-
RCG_D_OFFSET(rcg), mask, ~f->n);
296+
RCG_D_OFFSET(rcg), mask, not2d_val);
288297
if (ret)
289298
return ret;
290299
}

0 commit comments

Comments
 (0)