Skip to content

Commit 5f3d94e

Browse files
Tom Rixbroonie
authored andcommitted
ASoC: nau8825: fix bounds check for adc_delay
clang build reports sound/soc/codecs/nau8825.c:2826:31: error: overlapping comparisons always evaluate to false [-Werror,-Wtautological-overlap-compare] if (nau8825->adc_delay < 125 && nau8825->adc_delay > 500) ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ This is a bug, a logical-or should have been used. Fixes: fc0b096 ("ASoC: nau8825: Add delay control for input path") Signed-off-by: Tom Rix <trix@redhat.com> Acked-by: David Lin <CTLIN0@nuvoton.com> Link: https://lore.kernel.org/r/20230418120955.3230705-1-trix@redhat.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 6738053 commit 5f3d94e

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

sound/soc/codecs/nau8825.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2823,7 +2823,7 @@ static int nau8825_read_device_properties(struct device *dev,
28232823
ret = device_property_read_u32(dev, "nuvoton,adc-delay-ms", &nau8825->adc_delay);
28242824
if (ret)
28252825
nau8825->adc_delay = 125;
2826-
if (nau8825->adc_delay < 125 && nau8825->adc_delay > 500)
2826+
if (nau8825->adc_delay < 125 || nau8825->adc_delay > 500)
28272827
dev_warn(dev, "Please set the suitable delay time!\n");
28282828

28292829
nau8825->mclk = devm_clk_get(dev, "mclk");

0 commit comments

Comments
 (0)