Skip to content

Commit 622fa81

Browse files
Uwe Kleine-Königkrzk
authored andcommitted
memory: tegra210-emc: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/3e2951685dddbc0ab32244916a9849af206a6730.1702822744.git.u.kleine-koenig@pengutronix.de Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
1 parent dcefa03 commit 622fa81

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/memory/tegra/tegra210-emc-core.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1985,15 +1985,13 @@ static int tegra210_emc_probe(struct platform_device *pdev)
19851985
return err;
19861986
}
19871987

1988-
static int tegra210_emc_remove(struct platform_device *pdev)
1988+
static void tegra210_emc_remove(struct platform_device *pdev)
19891989
{
19901990
struct tegra210_emc *emc = platform_get_drvdata(pdev);
19911991

19921992
debugfs_remove_recursive(emc->debugfs.root);
19931993
tegra210_clk_emc_detach(emc->clk);
19941994
of_reserved_mem_device_release(emc->dev);
1995-
1996-
return 0;
19971995
}
19981996

19991997
static int __maybe_unused tegra210_emc_suspend(struct device *dev)
@@ -2053,7 +2051,7 @@ static struct platform_driver tegra210_emc_driver = {
20532051
.pm = &tegra210_emc_pm_ops,
20542052
},
20552053
.probe = tegra210_emc_probe,
2056-
.remove = tegra210_emc_remove,
2054+
.remove_new = tegra210_emc_remove,
20572055
};
20582056

20592057
module_platform_driver(tegra210_emc_driver);

0 commit comments

Comments
 (0)