Skip to content

Commit 6385ed8

Browse files
mtk-rex-bc-chenChun-Kuang Hu
authored andcommitted
drm/mediatek: dpi: Add dual edge sample mode support
To support RGB888_2X12_LE and RGB888_2X12_BE, dpi should sample on dual edge which could recude half data io pins. For RGB888_1X24, dpi just sample on single edge (rising or falling edge). Signed-off-by: Jitao Shi <jitao.shi@mediatek.com> Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com> Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
1 parent 69777e6 commit 6385ed8

1 file changed

Lines changed: 24 additions & 1 deletion

File tree

drivers/gpu/drm/mediatek/mtk_dpi.c

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ struct mtk_dpi {
8383
struct pinctrl *pinctrl;
8484
struct pinctrl_state *pins_gpio;
8585
struct pinctrl_state *pins_dpi;
86+
u32 output_fmt;
8687
int refcount;
8788
};
8889

@@ -381,6 +382,20 @@ static void mtk_dpi_config_color_format(struct mtk_dpi *dpi,
381382
}
382383
}
383384

385+
static void mtk_dpi_dual_edge(struct mtk_dpi *dpi)
386+
{
387+
if ((dpi->output_fmt == MEDIA_BUS_FMT_RGB888_2X12_LE) ||
388+
(dpi->output_fmt == MEDIA_BUS_FMT_RGB888_2X12_BE)) {
389+
mtk_dpi_mask(dpi, DPI_DDR_SETTING, DDR_EN | DDR_4PHASE,
390+
DDR_EN | DDR_4PHASE);
391+
mtk_dpi_mask(dpi, DPI_OUTPUT_SETTING,
392+
dpi->output_fmt == MEDIA_BUS_FMT_RGB888_2X12_LE ?
393+
EDGE_SEL : 0, EDGE_SEL);
394+
} else {
395+
mtk_dpi_mask(dpi, DPI_DDR_SETTING, DDR_EN | DDR_4PHASE, 0);
396+
}
397+
}
398+
384399
static void mtk_dpi_power_off(struct mtk_dpi *dpi)
385400
{
386401
if (WARN_ON(dpi->refcount == 0))
@@ -455,7 +470,13 @@ static int mtk_dpi_set_display_mode(struct mtk_dpi *dpi,
455470
pll_rate = clk_get_rate(dpi->tvd_clk);
456471

457472
vm.pixelclock = pll_rate / factor;
458-
clk_set_rate(dpi->pixel_clk, vm.pixelclock);
473+
if ((dpi->output_fmt == MEDIA_BUS_FMT_RGB888_2X12_LE) ||
474+
(dpi->output_fmt == MEDIA_BUS_FMT_RGB888_2X12_BE))
475+
clk_set_rate(dpi->pixel_clk, vm.pixelclock * 2);
476+
else
477+
clk_set_rate(dpi->pixel_clk, vm.pixelclock);
478+
479+
459480
vm.pixelclock = clk_get_rate(dpi->pixel_clk);
460481

461482
dev_dbg(dpi->dev, "Got PLL %lu Hz, pixel clock %lu Hz\n",
@@ -519,6 +540,7 @@ static int mtk_dpi_set_display_mode(struct mtk_dpi *dpi,
519540
mtk_dpi_config_yc_map(dpi, dpi->yc_map);
520541
mtk_dpi_config_color_format(dpi, dpi->color_format);
521542
mtk_dpi_config_2n_h_fre(dpi);
543+
mtk_dpi_dual_edge(dpi);
522544
mtk_dpi_config_disable_edge(dpi);
523545
mtk_dpi_sw_reset(dpi, false);
524546

@@ -718,6 +740,7 @@ static int mtk_dpi_probe(struct platform_device *pdev)
718740

719741
dpi->dev = dev;
720742
dpi->conf = (struct mtk_dpi_conf *)of_device_get_match_data(dev);
743+
dpi->output_fmt = MEDIA_BUS_FMT_RGB888_1X24;
721744

722745
dpi->pinctrl = devm_pinctrl_get(&pdev->dev);
723746
if (IS_ERR(dpi->pinctrl)) {

0 commit comments

Comments
 (0)