Skip to content

Commit 63ad216

Browse files
tobluxbrauner
authored andcommitted
fs: Replace simple_strtoul with kstrtoul in set_ihash_entries
Replace simple_strtoul() with the recommended kstrtoul() for parsing the 'ihash_entries=' boot parameter. Check the return value of kstrtoul() and reject invalid values. This adds error handling while preserving behavior for existing valid values, and removes use of the deprecated simple_strtoul() helper. Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> Link: https://patch.msgid.link/20251218112144.225301-2-thorsten.blum@linux.dev Reviewed-by: Jan Kara <jack@suse.cz> Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent b68f91e commit 63ad216

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

fs/inode.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2531,10 +2531,7 @@ static void __wait_on_freeing_inode(struct inode *inode, bool is_inode_hash_lock
25312531
static __initdata unsigned long ihash_entries;
25322532
static int __init set_ihash_entries(char *str)
25332533
{
2534-
if (!str)
2535-
return 0;
2536-
ihash_entries = simple_strtoul(str, &str, 0);
2537-
return 1;
2534+
return kstrtoul(str, 0, &ihash_entries) == 0;
25382535
}
25392536
__setup("ihash_entries=", set_ihash_entries);
25402537

0 commit comments

Comments
 (0)