Skip to content

Commit 6401e43

Browse files
committed
platform/chrome: cros_hps_i2c: Discard pm_runtime_put() return value
Passing pm_runtime_put() return value to the callers is not particularly useful. Returning an error code from pm_runtime_put() merely means that it has not queued up a work item to check whether or not the device can be suspended and there are many perfectly valid situations in which that can happen, like after writing "on" to the devices' runtime PM "control" attribute in sysfs for one example. It also happens when the kernel is configured with CONFIG_PM unset. Accordingly, update hps_release() to simply discard the return value of pm_runtime_put() and always return success to the caller. This will facilitate a planned change of the pm_runtime_put() return type to void in the future. Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Acked-by: Tzung-Bi Shih <tzungbi@kernel.org> Link: https://patch.msgid.link/2302270.NgBsaNRSFp@rafael.j.wysocki
1 parent 01eafcc commit 6401e43

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/platform/chrome/cros_hps_i2c.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,9 @@ static int hps_release(struct inode *inode, struct file *file)
4646
struct hps_drvdata, misc_device);
4747
struct device *dev = &hps->client->dev;
4848

49-
return pm_runtime_put(dev);
49+
pm_runtime_put(dev);
50+
51+
return 0;
5052
}
5153

5254
static const struct file_operations hps_fops = {

0 commit comments

Comments
 (0)