Skip to content

Commit 647e965

Browse files
Marek Vasutbjorn-helgaas
authored andcommitted
PCI: vmd: Silence 'set affinity failed' warning
Use MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity() unset and allows migrate_one_irq() to exit right away, without warnings like this: IRQ...: set affinity failed(-22) Remove the .irq_set_affinity() implementation that is no longer needed. Link: https://lore.kernel.org/r/20240723132958.41320-13-marek.vasut+renesas@mailbox.org Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> [bhelgaas: commit log] Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Reviewed-by: Nirmal Patel <nirmal.patel@linux.intel.com> Acked-by: Thomas Gleixner <tglx@linutronix.de>
1 parent 7216311 commit 647e965

1 file changed

Lines changed: 1 addition & 12 deletions

File tree

  • drivers/pci/controller

drivers/pci/controller/vmd.c

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -204,22 +204,11 @@ static void vmd_irq_disable(struct irq_data *data)
204204
raw_spin_unlock_irqrestore(&list_lock, flags);
205205
}
206206

207-
/*
208-
* XXX: Stubbed until we develop acceptable way to not create conflicts with
209-
* other devices sharing the same vector.
210-
*/
211-
static int vmd_irq_set_affinity(struct irq_data *data,
212-
const struct cpumask *dest, bool force)
213-
{
214-
return -EINVAL;
215-
}
216-
217207
static struct irq_chip vmd_msi_controller = {
218208
.name = "VMD-MSI",
219209
.irq_enable = vmd_irq_enable,
220210
.irq_disable = vmd_irq_disable,
221211
.irq_compose_msi_msg = vmd_compose_msi_msg,
222-
.irq_set_affinity = vmd_irq_set_affinity,
223212
};
224213

225214
static irq_hw_number_t vmd_get_hwirq(struct msi_domain_info *info,
@@ -326,7 +315,7 @@ static struct msi_domain_ops vmd_msi_domain_ops = {
326315

327316
static struct msi_domain_info vmd_msi_domain_info = {
328317
.flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
329-
MSI_FLAG_PCI_MSIX,
318+
MSI_FLAG_NO_AFFINITY | MSI_FLAG_PCI_MSIX,
330319
.ops = &vmd_msi_domain_ops,
331320
.chip = &vmd_msi_controller,
332321
};

0 commit comments

Comments
 (0)