Skip to content

Commit 7216311

Browse files
Marek Vasutbjorn-helgaas
authored andcommitted
PCI: tegra: Silence 'set affinity failed' warning
Use MSI_FLAG_NO_AFFINITY, which keeps .irq_set_affinity() unset and allows migrate_one_irq() to exit right away, without warnings like this: IRQ...: set affinity failed(-22) Remove the .irq_set_affinity() implementation that is no longer needed. Link: https://lore.kernel.org/r/20240723132958.41320-12-marek.vasut+renesas@mailbox.org Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> [bhelgaas: commit log] Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Acked-by: Thomas Gleixner <tglx@linutronix.de>
1 parent 57d1992 commit 7216311

1 file changed

Lines changed: 2 additions & 8 deletions

File tree

drivers/pci/controller/pci-tegra.c

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1629,11 +1629,6 @@ static void tegra_msi_irq_unmask(struct irq_data *d)
16291629
spin_unlock_irqrestore(&msi->mask_lock, flags);
16301630
}
16311631

1632-
static int tegra_msi_set_affinity(struct irq_data *d, const struct cpumask *mask, bool force)
1633-
{
1634-
return -EINVAL;
1635-
}
1636-
16371632
static void tegra_compose_msi_msg(struct irq_data *data, struct msi_msg *msg)
16381633
{
16391634
struct tegra_msi *msi = irq_data_get_irq_chip_data(data);
@@ -1648,7 +1643,6 @@ static struct irq_chip tegra_msi_bottom_chip = {
16481643
.irq_ack = tegra_msi_irq_ack,
16491644
.irq_mask = tegra_msi_irq_mask,
16501645
.irq_unmask = tegra_msi_irq_unmask,
1651-
.irq_set_affinity = tegra_msi_set_affinity,
16521646
.irq_compose_msi_msg = tegra_compose_msi_msg,
16531647
};
16541648

@@ -1697,8 +1691,8 @@ static const struct irq_domain_ops tegra_msi_domain_ops = {
16971691
};
16981692

16991693
static struct msi_domain_info tegra_msi_info = {
1700-
.flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
1701-
MSI_FLAG_PCI_MSIX),
1694+
.flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS |
1695+
MSI_FLAG_NO_AFFINITY | MSI_FLAG_PCI_MSIX,
17021696
.chip = &tegra_msi_top_chip,
17031697
};
17041698

0 commit comments

Comments
 (0)