Skip to content

Commit 66daf3e

Browse files
bulwahnmartinkpetersen
authored andcommitted
scsi: scsi_ioctl: Drop needless assignment in sg_io()
Commit ce70fd9 ("scsi: core: Remove the cmd field from struct scsi_request") refactored sg_io(), so that it does not allocate directly and hence does not return -ENOMEM in its error case. That makes a remaining assignment of -ENOMEM to the return variable needless. Drop this needless assignment in sg_io(). No functional change. No change in resulting object code. Link: https://lore.kernel.org/r/20220315061520.30745-1-lukas.bulwahn@gmail.com Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent dc155e1 commit 66daf3e

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/scsi/scsi_ioctl.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,6 @@ static int sg_io(struct scsi_device *sdev, struct sg_io_hdr *hdr, fmode_t mode)
434434
if (hdr->flags & SG_FLAG_Q_AT_HEAD)
435435
at_head = 1;
436436

437-
ret = -ENOMEM;
438437
rq = scsi_alloc_request(sdev->request_queue, writing ?
439438
REQ_OP_DRV_OUT : REQ_OP_DRV_IN, 0);
440439
if (IS_ERR(rq))

0 commit comments

Comments
 (0)