Skip to content

Commit 69343ce

Browse files
rfvirgilbroonie
authored andcommitted
firmware: cirrus: cs_dsp: Only log list of algorithms in debug build
Change the logging of each algorithm from info level to debug level. On the original devices supported by this code there were typically only one or two algorithms in a firmware and one or two DSPs so this logging only used a small number of log lines. However, for the latest devices there could be 30-40 algorithms in a firmware and 8 DSPs being loaded in parallel, so using 300+ lines of log for information that isn't particularly important to have logged. Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> Link: https://lore.kernel.org/r/20230913160523.3701189-1-rf@opensource.cirrus.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent cf0ba44 commit 69343ce

1 file changed

Lines changed: 17 additions & 17 deletions

File tree

drivers/firmware/cirrus/cs_dsp.c

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1863,15 +1863,15 @@ static int cs_dsp_adsp2_setup_algs(struct cs_dsp *dsp)
18631863
return PTR_ERR(adsp2_alg);
18641864

18651865
for (i = 0; i < n_algs; i++) {
1866-
cs_dsp_info(dsp,
1867-
"%d: ID %x v%d.%d.%d XM@%x YM@%x ZM@%x\n",
1868-
i, be32_to_cpu(adsp2_alg[i].alg.id),
1869-
(be32_to_cpu(adsp2_alg[i].alg.ver) & 0xff0000) >> 16,
1870-
(be32_to_cpu(adsp2_alg[i].alg.ver) & 0xff00) >> 8,
1871-
be32_to_cpu(adsp2_alg[i].alg.ver) & 0xff,
1872-
be32_to_cpu(adsp2_alg[i].xm),
1873-
be32_to_cpu(adsp2_alg[i].ym),
1874-
be32_to_cpu(adsp2_alg[i].zm));
1866+
cs_dsp_dbg(dsp,
1867+
"%d: ID %x v%d.%d.%d XM@%x YM@%x ZM@%x\n",
1868+
i, be32_to_cpu(adsp2_alg[i].alg.id),
1869+
(be32_to_cpu(adsp2_alg[i].alg.ver) & 0xff0000) >> 16,
1870+
(be32_to_cpu(adsp2_alg[i].alg.ver) & 0xff00) >> 8,
1871+
be32_to_cpu(adsp2_alg[i].alg.ver) & 0xff,
1872+
be32_to_cpu(adsp2_alg[i].xm),
1873+
be32_to_cpu(adsp2_alg[i].ym),
1874+
be32_to_cpu(adsp2_alg[i].zm));
18751875

18761876
alg_region = cs_dsp_create_region(dsp, WMFW_ADSP2_XM,
18771877
adsp2_alg[i].alg.id,
@@ -1996,14 +1996,14 @@ static int cs_dsp_halo_setup_algs(struct cs_dsp *dsp)
19961996
return PTR_ERR(halo_alg);
19971997

19981998
for (i = 0; i < n_algs; i++) {
1999-
cs_dsp_info(dsp,
2000-
"%d: ID %x v%d.%d.%d XM@%x YM@%x\n",
2001-
i, be32_to_cpu(halo_alg[i].alg.id),
2002-
(be32_to_cpu(halo_alg[i].alg.ver) & 0xff0000) >> 16,
2003-
(be32_to_cpu(halo_alg[i].alg.ver) & 0xff00) >> 8,
2004-
be32_to_cpu(halo_alg[i].alg.ver) & 0xff,
2005-
be32_to_cpu(halo_alg[i].xm_base),
2006-
be32_to_cpu(halo_alg[i].ym_base));
1999+
cs_dsp_dbg(dsp,
2000+
"%d: ID %x v%d.%d.%d XM@%x YM@%x\n",
2001+
i, be32_to_cpu(halo_alg[i].alg.id),
2002+
(be32_to_cpu(halo_alg[i].alg.ver) & 0xff0000) >> 16,
2003+
(be32_to_cpu(halo_alg[i].alg.ver) & 0xff00) >> 8,
2004+
be32_to_cpu(halo_alg[i].alg.ver) & 0xff,
2005+
be32_to_cpu(halo_alg[i].xm_base),
2006+
be32_to_cpu(halo_alg[i].ym_base));
20072007

20082008
ret = cs_dsp_halo_create_regions(dsp, halo_alg[i].alg.id,
20092009
halo_alg[i].alg.ver,

0 commit comments

Comments
 (0)