Skip to content

Commit 6961fed

Browse files
rddunlapChristian Brauner
authored andcommitted
xattr: fix kernel-doc for mnt_userns and vfs xattr helpers
Fix kernel-doc warnings in xattr.c: ../fs/xattr.c:257: warning: Function parameter or member 'mnt_userns' not described in '__vfs_setxattr_locked' ../fs/xattr.c:485: warning: Function parameter or member 'mnt_userns' not described in '__vfs_removexattr_locked' and fix one function whose kernel-doc was not in the correct format. Link: https://lore.kernel.org/r/20210216042929.8931-4-rdunlap@infradead.org Fixes: 71bc356 ("commoncap: handle idmapped mounts") Fixes: b1ab7e4 ("VFS: Factor out part of vfs_setxattr so it can be called from the SELinux hook for inode_setsecctx.") Signed-off-by: Randy Dunlap <rdunlap@infradead.org> Cc: David Howells <dhowells@redhat.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: linux-fsdevel@vger.kernel.org Cc: Christian Brauner <christian.brauner@ubuntu.com> Cc: David P. Quigley <dpquigl@tycho.nsa.gov> Cc: James Morris <jmorris@namei.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Acked-by: Christian Brauner <christian.brauner@ubuntu.com> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
1 parent 2111c3c commit 6961fed

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

fs/xattr.c

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -186,12 +186,12 @@ EXPORT_SYMBOL(__vfs_setxattr);
186186
* __vfs_setxattr_noperm - perform setxattr operation without performing
187187
* permission checks.
188188
*
189-
* @mnt_userns - user namespace of the mount the inode was found from
190-
* @dentry - object to perform setxattr on
191-
* @name - xattr name to set
192-
* @value - value to set @name to
193-
* @size - size of @value
194-
* @flags - flags to pass into filesystem operations
189+
* @mnt_userns: user namespace of the mount the inode was found from
190+
* @dentry: object to perform setxattr on
191+
* @name: xattr name to set
192+
* @value: value to set @name to
193+
* @size: size of @value
194+
* @flags: flags to pass into filesystem operations
195195
*
196196
* returns the result of the internal setxattr or setsecurity operations.
197197
*
@@ -242,6 +242,7 @@ int __vfs_setxattr_noperm(struct user_namespace *mnt_userns,
242242
* __vfs_setxattr_locked - set an extended attribute while holding the inode
243243
* lock
244244
*
245+
* @mnt_userns: user namespace of the mount of the target inode
245246
* @dentry: object to perform setxattr on
246247
* @name: xattr name to set
247248
* @value: value to set @name to
@@ -473,6 +474,7 @@ EXPORT_SYMBOL(__vfs_removexattr);
473474
* __vfs_removexattr_locked - set an extended attribute while holding the inode
474475
* lock
475476
*
477+
* @mnt_userns: user namespace of the mount of the target inode
476478
* @dentry: object to perform setxattr on
477479
* @name: name of xattr to remove
478480
* @delegated_inode: on return, will contain an inode pointer that

0 commit comments

Comments
 (0)